linux-kernel - Re: [PATCH bpf v8 2/5] bpf: fix wrong copied

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cwd4ezi6lnvbdiqtzwvfzayzvziu7xibobmdgqirbhuhlgzdv6@vsbxhyqa44ko>
Date: Wed, 22 Jan 2025 16:55:01 +0800
From: Jiayuan Chen <mrpre@....com>
To: Jakub Sitnicki <jakub@...udflare.com>
Cc: bpf@...r.kernel.org, john.fastabend@...il.com, netdev@...r.kernel.org, 
	martin.lau@...ux.dev, ast@...nel.org, edumazet@...gle.com, davem@...emloft.net, 
	dsahern@...nel.org, kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org, 
	song@...nel.org, andrii@...nel.org, mhal@...x.co, yonghong.song@...ux.dev, 
	daniel@...earbox.net, xiyou.wangcong@...il.com, horms@...nel.org, corbet@....net, 
	eddyz87@...il.com, cong.wang@...edance.com, shuah@...nel.org, mykolal@...com, 
	jolsa@...nel.org, haoluo@...gle.com, sdf@...ichev.me, kpsingh@...nel.org, 
	linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf v8 2/5] bpf: fix wrong copied_seq calculation

On Tue, Jan 21, 2025 at 03:18:38PM +0100, Jakub Sitnicki wrote:
> On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote:
> > 'sk->copied_seq' was updated in the tcp_eat_skb() function when the
> > action of a BPF program was SK_REDIRECT. For other actions, like SK_PASS,
> > the update logic for 'sk->copied_seq' was moved to
> > tcp_bpf_recvmsg_parser() to ensure the accuracy of the 'fionread' feature.
> >
> > It works for a single stream_verdict scenario, as it also modified
> > 'sk_data_ready->sk_psock_verdict_data_ready->tcp_read_skb'
> > to remove updating 'sk->copied_seq'.
> >
> > However, for programs where both stream_parser and stream_verdict are
> > active(strparser purpose), tcp_read_sock() was used instead of
> 
> Nit: missing space, "active (strparser purpose)"
>             ^
> 
> > tcp_read_skb() (sk_data_ready->strp_data_ready->tcp_read_sock)
> 
> Nit: missing period, "… (sk_data_ready->strp_data_ready->tcp_read_sock)."
>                                                                        ^
> 
> > tcp_read_sock() now still update 'sk->copied_seq', leading to duplicated
> 
> Nit: grammar "still updates"
>                           ^
> Please run commit descriptions through a language tool or an LLM, if
> possible. This makes reviewing easier.
> 
Thanks Jakub, I'll review all commit messages and code comments, and also
use LLLM for grammar checks.