linux-kernel - Re: [PATCH] vbox: add HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <776553f3-74a6-4357-ab10-b5b25812b4a8@redhat.com>
Date: Wed, 22 Jan 2025 10:47:15 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Arnd Bergmann <arnd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Christian Brauner <brauner@...nel.org>,
 Christian Kujau <lists@...dbynature.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vbox: add HAS_IOPORT dependency

Hi,

On 22-Jan-25 7:54 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The vboxguest driver depends on port I/O for debug output:
> 
> include/asm-generic/io.h:626:15: error: call to '_outl' declared with attribute error: outl() requires CONFIG_HAS_IOPORT
>   626 | #define _outl _outl
> include/asm-generic/io.h:663:14: note: in expansion of macro '_outl'
>   663 | #define outl _outl
>       |              ^~~~~
> drivers/virt/vboxguest/vboxguest_utils.c:102:9: note: in expansion of macro 'outl'
>   102 |         outl(phys_req, gdev->io_port + VMMDEV_PORT_OFF_REQUEST);
>       |         ^~~~
> 
> Most arm64 platforms don't actually support port I/O, though it is
> currently enabled unconditionally. Refine the vbox dependency to allow
> turning it HAS_IOPORT off in the future when building for platforms
> without port I/O and allow compile-testing on all architectures.
> 
> Fixes: 5cf8f938bf5c ("vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>  drivers/virt/vboxguest/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/virt/vboxguest/Kconfig b/drivers/virt/vboxguest/Kconfig
> index 11b153e7454e..eaba28c95e73 100644
> --- a/drivers/virt/vboxguest/Kconfig
> +++ b/drivers/virt/vboxguest/Kconfig
> @@ -1,7 +1,8 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config VBOXGUEST
>  	tristate "Virtual Box Guest integration support"
> -	depends on (ARM64 || X86) && PCI && INPUT
> +	depends on (ARM64 || X86 || COMPILE_TEST) && PCI && INPUT
> +	depends on HAS_IOPORT
>  	help
>  	  This is a driver for the Virtual Box Guest PCI device used in
>  	  Virtual Box virtual machines. Enabling this driver will add