linux-kernel - Re: [PATCH v3] mm: gup: fix infinite loop within __get_longterm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84ae07bf-de57-4b66-bc18-c94727a92cfe@redhat.com>
Date: Wed, 22 Jan 2025 12:19:38 +0100
From: David Hildenbrand <david@...hat.com>
To: "zhaoyang.huang" <zhaoyang.huang@...soc.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Alistair Popple <apopple@...dia.com>, John Hubbard <jhubbard@...dia.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Zhaoyang Huang <huangzhaoyang@...il.com>, steve.kang@...soc.com,
 aijun.sun@...soc.com
Subject: Re: [PATCH v3] mm: gup: fix infinite loop within
 __get_longterm_locked

On 22.01.25 02:26, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@...soc.com>
> 
> We can run into an infinite loop in __get_longterm_locked() when
> collect_longterm_unpinnable_folios() finds only folios that are isolated
> from the LRU or were never added to the LRU. This can happen when all
> folios to be pinned are never added to the LRU, for example when
> vm_ops->fault allocated pages using cma_alloc() and never added them to
> the LRU.
> 
> Fix it by simply taking a look at the list in the single caller, to see
> if anything was added.
> 
> Fixes: 67e139b02d99 ("mm/gup.c: refactor check_and_migrate_movable_pages()")
> 
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> Suggested-by: David Hildenbrand <david@...hat.com>

^ you should CC all people here. "git send-email" will usually try doing 
that automatically. :)



Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb