linux-kernel - Re: [GIT PULL] RCU changes for v6.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5DWQHUxpUpwd7W-@pc636>
Date: Wed, 22 Jan 2025 12:28:00 +0100
From: Uladzislau Rezki <urezki@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: "Uladzislau Rezki (Sony)" <urezki@...il.com>, RCU <rcu@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Paul E . McKenney" <paulmck@...nel.org>,
	Feng Lee <379943137@...com>,
	Neeraj upadhyay <Neeraj.Upadhyay@....com>,
	Boqun Feng <boqun.feng@...il.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Frederic Weisbecker <frederic@...nel.org>,
	Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [GIT PULL] RCU changes for v6.14

On Tue, Jan 21, 2025 at 02:51:15PM -0800, Linus Torvalds wrote:
> On Fri, 17 Jan 2025 at 09:24, Uladzislau Rezki (Sony) <urezki@...il.com> wrote:
> >
> > Please pull the latest RCU git tree from:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux.git tags/rcu.release.v6.14
> 
> Hmm. I have pulled this, and the resulting shortlog matches what you
> say I should have gotten.
> 
> But your diffstat is odd and looks very wrong.
> 
> Things like this:
> 
> >  tools/testing/selftests/bpf/map_tests/lpm_trie_map_basic_ops.c |  395 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> were already in my tree from before, and aren't new (and your shortlog
> doesn't mention them).
> 
> Also, look at that line. It's long. It's not supposed to be that long.
> You've presumably generated this (incorrect) diffstat in a very wide
> terminal, and then cut-and-pasted that very wide output into the
> email.
> 
> Please don't do that. Yes, git will default to wide output if the
> output is a wide terminal, but if you either pipe it into something
> else (may I suggest "xsel", so that it goes directly into your X
> clipboard).
> 
> Or use "--stat=80" to limit the width manually to 80 columns.
> 
> But the strange formatting is the less worrisome issue. The diffstat
> just being plain wrong is the more alarming thing.
>
Thank you for taking this in!

My script that generates a diff-stat is not perfect, i will fix it.
Sorry this is my bad.

--
Uladzislau Rezki