linux-kernel - Re: [RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3639243f-ac84-4c28-b78d-c82aef672782@kernel.org>
Date: Wed, 22 Jan 2025 12:36:42 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michal Wilczynski <m.wilczynski@...sung.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, drew@...7.com, guoren@...nel.org,
 wefu@...hat.com, jassisinghbrar@...il.com, paul.walmsley@...ive.com,
 palmer@...belt.com, aou@...s.berkeley.edu, frank.binns@...tec.com,
 matt.coster@...tec.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 ulf.hansson@...aro.org, jszhang@...nel.org, p.zabel@...gutronix.de,
 m.szyprowski@...sung.com, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, dri-devel@...ts.freedesktop.org,
 linux-pm@...r.kernel.org
Subject: Re: [RFC v3 05/18] pmdomain: thead: Add power-domain driver for
 TH1520

On 22/01/2025 12:26, Michal Wilczynski wrote:
>>>
>>> These power-domain constants are defined by the AON firmware protocol,
>>> which dictates the exact IDs (e.g., 1 for NPU). They are not just array
>>> indices; we must use these specific values to communicate with the
>>> firmware correctly. Using array indices starting with 1 would be
>>> unusual.
>>
>> Then that's a no. Binding constants do not represent values used by your
>> hardware. The binding constant should start from 0.
> 
> Would it be a problem if those overlapped ? There is one more value that

No, I just don't care about hardware constants here. Use the bindings
constants in your driver at least as abstract IDs or these are not
suitable for bindings.

Best regards,
Krzysztof