linux-kernel - Re: [PATCH 00/10] media: rcar: Minor cleanups and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p2f3d5tm4ufax2ubgrsfm75c754mu2pdnkzmtopzwwebyuhcjf@i3dttqpg5myu>
Date: Wed, 22 Jan 2025 12:57:13 +0100
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Niklas Söderlund <niklas.soderlund@...natech.se>
Cc: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/10] media: rcar: Minor cleanups and improvements

Hi Niklas,

On Wed, Jan 22, 2025 at 10:21:28AM +0100, Niklas Söderlund wrote:
> On 2025-01-22 10:02:59 +0200, Tomi Valkeinen wrote:
> > Hi,
> >
> > On 21/01/2025 23:24, Niklas Söderlund wrote:
> > > Hi Tomi,
> > >
> > > Thanks for a great cleanup series!
> > >
> > > On 2025-01-20 15:10:33 +0200, Tomi Valkeinen wrote:
> > > > I've started looking at multi-stream support, and came up with these
> > > > while working towards streams.
> > > >
> > > >   Tomi
> > > >
> > > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> > >
> > > I have tested this in Gen2, Gen3 and Gen4 without noticing any
> > > regressions. The log is now spammed with the helpful suggestion that the
> > > CSI-2 TX subdevices shall implement V4L2_CID_LINK_FREQ control. This is
> > > annoying but out of scope for this series, but would be nice at some
> > > point.
> > >
> > >    [   37.421531] v4l2_get_link_freq: Link frequency estimated using pixel rate: result might be inaccurate
> > >    [   37.430991] v4l2_get_link_freq: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver
> >
> > Which drivers need fixing? The staging max96712 is one (there seems to be a
> > TODO there about it), and adv748x? I'm not going to work on that right now,
> > but just collecting the details.
>
> Indeed adv748x is the other driver needing work here. The problem as I
> recall it is that V4L2_CID_LINK_FREQ is a menu control, and adv748x
> selects it link freq based on what it is outputting. But it's been some
> time since I looked at this, maybe I recall incorrectly.
>

Would this series help ?
https://patchwork.kernel.org/project/linux-media/list/?series=926905

> >
> > > For the whole series,
> > >
> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> > > Tested-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> >
> > Thanks!
> >
> >  Tomi
> >
>
> --
> Kind Regards,
> Niklas Söderlund
>