linux-kernel - [PATCH] Input: himax_hx83112b - fix event stack size to clear irq correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250122121409.1374602-1-mastichi@gmail.com>
Date: Wed, 22 Jan 2025 15:14:09 +0300
From: Dmitry Mastykin <mastichi@...il.com>
To: job@...rman.info,
	dmitry.torokhov@...il.com,
	linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	felix@...chele.ca
Cc: Dmitry Mastykin <mastichi@...il.com>
Subject: [PATCH] Input: himax_hx83112b - fix event stack size to clear irq correctly

The datasheet suggests that the size of the event stack is 32 x 32-bit.
Reading less bytes did not clear the interrupt output. Extra interrupts
were called with zero himax_event_get_num_points() result.
Only every second call to himax_handle_input() cleared the interrupt
output.

Tested on: HX83102J

Signed-off-by: Dmitry Mastykin <mastichi@...il.com>
---
 drivers/input/touchscreen/himax_hx83112b.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/himax_hx83112b.c b/drivers/input/touchscreen/himax_hx83112b.c
index 31f18860dbd3..fe7bdf8cec50 100644
--- a/drivers/input/touchscreen/himax_hx83112b.c
+++ b/drivers/input/touchscreen/himax_hx83112b.c
@@ -24,6 +24,7 @@
 #include <linux/regmap.h>
 
 #define HIMAX_MAX_POINTS		10
+#define HIMAX_EVENT_STACK_SIZE		128
 
 #define HIMAX_AHB_ADDR_BYTE_0			0x00
 #define HIMAX_AHB_ADDR_RDATA_BYTE_0		0x08
@@ -292,9 +293,9 @@ static int hx83100a_read_events(struct himax_ts_data *ts,
 static int himax_handle_input(struct himax_ts_data *ts)
 {
 	int error;
-	struct himax_event event;
+	u8 event[HIMAX_EVENT_STACK_SIZE];
 
-	error = ts->chip->read_events(ts, &event, sizeof(event));
+	error = ts->chip->read_events(ts, (struct himax_event *)&event, sizeof(event));
 	if (error) {
 		dev_err(&ts->client->dev, "Failed to read input event: %d\n",
 			error);
@@ -305,8 +306,8 @@ static int himax_handle_input(struct himax_ts_data *ts)
 	 * Only process the current event when it has a valid checksum but
 	 * don't consider it a fatal error when it doesn't.
 	 */
-	if (himax_verify_checksum(ts, &event))
-		himax_process_event(ts, &event);
+	if (himax_verify_checksum(ts, (struct himax_event *)&event))
+		himax_process_event(ts, (struct himax_event *)&event);
 
 	return 0;
 }
-- 
2.34.1