linux-kernel - Re: [PATCH net-next v04 1/1] hinic3: module initialization and tx/rx logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566b3d82-5e66-4e97-9808-a0e8e212fe67@intel.com>
Date: Wed, 22 Jan 2025 14:58:31 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Gur Stavi <gur.stavi@...wei.com>
CC: <andrew+netdev@...n.ch>, <cai.huoqing@...ux.dev>, <corbet@....net>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <gongfan1@...wei.com>,
	<guoxin09@...wei.com>, <helgaas@...nel.org>, <horms@...nel.org>,
	<kuba@...nel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <luosifu@...wei.com>,
	<meny.yossefi@...wei.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<shenchenyang1@...ilicon.com>, <shijing34@...wei.com>, <sumang@...vell.com>,
	<wulike1@...wei.com>, <zhoushuai28@...wei.com>
Subject: Re: [PATCH net-next v04 1/1] hinic3: module initialization and tx/rx
 logic

On 1/22/25 08:07, Gur Stavi wrote:
>>> Auxiliary driver registration.
>>> Net device_ops registration but open/stop are empty stubs.
>>> tx/rx logic.
>>
>> Take care for spelling: Tx/Rx; HW (just below).
> 
> Please elaborate. Spelling of what?

In all code comments and commit messages the acronyms and abbreviations
have their proper spelling, like "Tx", "Rx", "HW', "SW", "ID".

of course lowercase names are still allowed for variables/fields

> 
>>
>>>
>>> All major data structures of the driver are fully introduced with the
>>> code that uses them but without their initialization code that requires
>>> management interface with the hw.