linux-kernel - Re: [PATCH] ALSA: lola: Remove unused lola_(save|restore)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5BU62Go409LFd81@gallifrey>
Date: Wed, 22 Jan 2025 02:16:11 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: perex@...ex.cz, tiwai@...e.com
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: lola: Remove unused lola_(save|restore)_mixer

* linux@...blig.org (linux@...blig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> lola_restore_mixer() and lola_save_mixer() were added in 2011 by
> commit d43f3010b8fa ("ALSA: Add the driver for Digigram Lola
> PCI-e boards")
> but have remain unused.
> 
> Remove them.

NAK!
This lost the .c file change.
I'll do a v2.

Dave

> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  sound/pci/lola/lola.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/pci/lola/lola.h b/sound/pci/lola/lola.h
> index 0ff772cf66e6..25f72f9e3f9b 100644
> --- a/sound/pci/lola/lola.h
> +++ b/sound/pci/lola/lola.h
> @@ -499,8 +499,6 @@ int lola_init_mixer_widget(struct lola *chip, int nid);
>  void lola_free_mixer(struct lola *chip);
>  int lola_create_mixer(struct lola *chip);
>  int lola_setup_all_analog_gains(struct lola *chip, int dir, bool mute);
> -void lola_save_mixer(struct lola *chip);
> -void lola_restore_mixer(struct lola *chip);
>  int lola_set_src_config(struct lola *chip, unsigned int src_mask, bool update);
>  
>  /* proc */
> -- 
> 2.48.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/