linux-kernel - Re: [PATCH v2 2/8] scsi: ufs: qcom: Pass target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c493756f7ce5aee8a9a6856473c8d61a1128f2c6.camel@gmail.com>
Date: Wed, 22 Jan 2025 15:29:32 +0100
From: Bean Huo <huobean@...il.com>
To: Ziqi Chen <quic_ziqichen@...cinc.com>, quic_cang@...cinc.com, 
 bvanassche@....org, mani@...nel.org, beanhuo@...ron.com,
 avri.altman@....com,  junwoo80.lee@...sung.com, martin.petersen@...cle.com,
 quic_nguyenb@...cinc.com,  quic_nitirawa@...cinc.com,
 quic_rampraka@...cinc.com
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org, Manivannan
	Sadhasivam <manivannan.sadhasivam@...aro.org>, "James E.J. Bottomley"
	 <James.Bottomley@...senPartnership.com>, open list
	 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/8] scsi: ufs: qcom: Pass target_freq to clk scale
 pre and post change

On Wed, 2025-01-22 at 18:02 +0800, Ziqi Chen wrote:
> From: Can Guo <quic_cang@...cinc.com>
> 
> Instead of only two frequencies, If OPP V2 is used, the UFS devfreq
> clock
> scaling may scale the clock among multiple frequencies. In the case
> of
> scaling up, the devfreq may decide to scale the clock to an
> intermidiate
> freq base on load, but the clock scale up pre change operation uses
> settings for the max clock freq unconditionally. Fix it by passing
> the
> target_freq to clock scale up pre change so that the correct settings
> for
> the target_freq can be used.
> 
> In the case of scaling down, the clock scale down post change
> operation
> is doing fine, because it reads the actual clock rate to tell freq,
> but to
> keep symmetry with clock scale up pre change operation, just use the
> target_freq instead of reading clock rate.
> 
> Signed-off-by: Can Guo <quic_cang@...cinc.com>
> Co-developed-by: Ziqi Chen <quic_ziqichen@...cinc.com>
> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>

Reviewed-by: Bean Huo <beanhuo@...ron.com>