linux-kernel - Re: [PATCH v6 02/12] x86/mm: remove pv_ops.mmu.tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc2ddbbe443fb33f7ea51c10c5ae611aee7b5431.camel@surriel.com>
Date: Wed, 22 Jan 2025 10:48:47 -0500
From: Rik van Riel <riel@...riel.com>
To: Peter Zijlstra <peterz@...radead.org>, David Hildenbrand
 <david@...hat.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, bp@...en8.de, 
	dave.hansen@...ux.intel.com, zhengqi.arch@...edance.com,
 nadav.amit@...il.com, 	thomas.lendacky@....com, kernel-team@...a.com,
 linux-mm@...ck.org, 	akpm@...ux-foundation.org, jannh@...gle.com,
 mhklinux@...look.com, 	andrew.cooper3@...rix.com
Subject: Re: [PATCH v6 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call

On Tue, 2025-01-21 at 09:54 +0100, Peter Zijlstra wrote:
> On Tue, Jan 21, 2025 at 08:46:04AM +0100, David Hildenbrand wrote:
> > On 21.01.25 02:03, Rik van Riel wrote:
> > > On Mon, 2025-01-20 at 20:47 +0100, David Hildenbrand wrote:
> > > > On 20.01.25 03:40, Rik van Riel wrote:
> > > > > Every pv_ops.mmu.tlb_remove_table call ends up calling
> > > > > tlb_remove_table.
> > > > > 
> > > > 
> > > > Indeed, but the !CONFIG_PARAVIRT variant
> > > > paravirt_tlb_remove_table()
> > > > however calls tlb_remove_page().
> > > 
> > > Patch 1/12 from this series removes that.
> > > 
> > > After patch 1/12, we always call tlb_remove_table everywhere.
> > 
> > This patch contains the hunk:
> > 
> > -#ifndef CONFIG_PARAVIRT
> > -static inline
> > -void paravirt_tlb_remove_table(struct mmu_gather *tlb, void
> > *table)
> > -{
> > -	tlb_remove_page(tlb, table);
> > -}
> > -#endif
> > -
> > 
> > That is the source of my confusion.
> 
> Ah, that hunk should probably go to patch 1
> 
Moved that over for the next version.


-- 
All Rights Reversed.