linux-kernel - Re: [PATCH v2 1/2] thermal/drivers/qoriq: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5EULLr7hsk1RIZy@lizhi-Precision-Tower-5810>
Date: Wed, 22 Jan 2025 10:52:12 -0500
From: Frank Li <Frank.li@....com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	"open list:THERMAL" <linux-pm@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH v2 1/2] thermal/drivers/qoriq: Use dev_err_probe()
 simplify the code

On Mon, Dec 09, 2024 at 11:48:58AM -0500, Frank Li wrote:
> Use dev_err_probe() and devm_clk_get_optional_enabled() to simplify the
> code.
>
> Signed-off-by: Frank Li <Frank.Li@....com>

Rafael J. Wysocki:

	Do you have chance to check this patches?

Frank

> ---
> change from v1 to v2
> - Remove clk_disable_unprepare() in qoriq_tmu_action()
> ---
>  drivers/thermal/qoriq_thermal.c | 34 ++++++++++-----------------------
>  1 file changed, 10 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
> index 52e26be8c53df..183af15c33769 100644
> --- a/drivers/thermal/qoriq_thermal.c
> +++ b/drivers/thermal/qoriq_thermal.c
> @@ -265,7 +265,6 @@ static void qoriq_tmu_action(void *p)
>  	struct qoriq_tmu_data *data = p;
>
>  	regmap_write(data->regmap, REGS_TMR, TMR_DISABLE);
> -	clk_disable_unprepare(data->clk);
>  }
>
>  static int qoriq_tmu_probe(struct platform_device *pdev)
> @@ -296,38 +295,27 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
>
>  	base = devm_platform_ioremap_resource(pdev, 0);
>  	ret = PTR_ERR_OR_ZERO(base);
> -	if (ret) {
> -		dev_err(dev, "Failed to get memory region\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to get memory region\n");
>
>  	data->regmap = devm_regmap_init_mmio(dev, base, &regmap_config);
>  	ret = PTR_ERR_OR_ZERO(data->regmap);
> -	if (ret) {
> -		dev_err(dev, "Failed to init regmap (%d)\n", ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to init regmap\n");
>
> -	data->clk = devm_clk_get_optional(dev, NULL);
> +	data->clk = devm_clk_get_optional_enabled(dev, NULL);
>  	if (IS_ERR(data->clk))
>  		return PTR_ERR(data->clk);
>
> -	ret = clk_prepare_enable(data->clk);
> -	if (ret) {
> -		dev_err(dev, "Failed to enable clock\n");
> -		return ret;
> -	}
> -
>  	ret = devm_add_action_or_reset(dev, qoriq_tmu_action, data);
>  	if (ret)
>  		return ret;
>
>  	/* version register offset at: 0xbf8 on both v1 and v2 */
>  	ret = regmap_read(data->regmap, REGS_IPBRR(0), &ver);
> -	if (ret) {
> -		dev_err(&pdev->dev, "Failed to read IP block version\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret,  "Failed to read IP block version\n");
> +
>  	data->ver = (ver >> 8) & 0xff;
>
>  	qoriq_tmu_init_device(data);	/* TMU initialization */
> @@ -337,10 +325,8 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
>  		return ret;
>
>  	ret = qoriq_tmu_register_tmu_zone(dev, data);
> -	if (ret < 0) {
> -		dev_err(dev, "Failed to register sensors\n");
> -		return ret;
> -	}
> +	if (ret < 0)
> +		return dev_err_probe(dev, ret, "Failed to register sensors\n");
>
>  	platform_set_drvdata(pdev, data);
>
> --
> 2.34.1
>