linux-kernel - Re: [RFC PATCH 03/10] net: ti: prueth: Adds PRUETH HW and SW configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1841709010.384806.1737561461669.JavaMail.zimbra@couthit.local>
Date: Wed, 22 Jan 2025 21:27:41 +0530 (IST)
From: Basharath Hussain Khaja <basharath@...thit.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: basharath <basharath@...thit.com>, danishanwar <danishanwar@...com>, 
	rogerq <rogerq@...nel.org>, andrew+netdev <andrew+netdev@...n.ch>, 
	davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>, 
	kuba <kuba@...nel.org>, pabeni <pabeni@...hat.com>, 
	Rob Herring <robh@...nel.org>, krzk+dt <krzk+dt@...nel.org>, 
	conor+dt <conor+dt@...nel.org>, nm <nm@...com>, 
	ssantosh <ssantosh@...nel.org>, tony <tony@...mide.com>, 
	richardcochran <richardcochran@...il.com>, 
	parvathi <parvathi@...thit.com>, schnelle <schnelle@...ux.ibm.com>, 
	rdunlap <rdunlap@...radead.org>, diogo ivo <diogo.ivo@...mens.com>, 
	m-karicheri2 <m-karicheri2@...com>, horms <horms@...nel.org>, 
	jacob e keller <jacob.e.keller@...el.com>, 
	m-malladi <m-malladi@...com>, 
	javier carrasco cruz <javier.carrasco.cruz@...il.com>, 
	afd <afd@...com>, s-anna <s-anna@...com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	netdev <netdev@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-omap <linux-omap@...r.kernel.org>, 
	pratheesh <pratheesh@...com>, prajith <prajith@...com>, 
	vigneshr <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>, 
	mohan <mohan@...thit.com>
Subject: Re: [RFC PATCH 03/10] net: ti: prueth: Adds PRUETH HW and SW
 configuration


>> +/* Below macro is for 1528 Byte Frame support, to Allow even with
>> + * Redundancy tag
>> + */
>> +#define PRUSS_MII_RT_RX_FRMS_MAX_SUPPORT_EMAC	(VLAN_ETH_FRAME_LEN + \
>> +							ETH_FCS_LEN + 6)
> 
> Is 6 for the redundancy tag? Is the redundancy tag defined somewhere?
> Could this 6 be replaced by a #define, which is maybe a sizeof()?
>

Yes. 6 is for redundancy tag. We will create a MACRO and use 
MACRO instead of hard coded value.
 
>> +	dev_info(dev, "TI PRU ethernet driver initialized: %s EMAC mode\n",
>> +		 (!eth0_node || !eth1_node) ? "single" : "dual");
>> +
> 
> Is that really true? Is it not in dual mode, but only one interface is
> in use? I also wounder at the value of spamming the log like this.
> 

This might be valid if in case user decides to use only one MAC port by 
changing dts configuration.

Thanks & Best Regards,
Basharath