linux-kernel - Re: [PATCH v3] acpi: Fix HED module initialization order when it is built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ihVJBX0bLqrL-61=LKVoZJOg3RpJykp80uOMf_7YcG+A@mail.gmail.com>
Date: Thu, 23 Jan 2025 20:35:51 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Xiaofei Tan <tanxiaofei@...wei.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>, rafael@...nel.org, lenb@...nel.org, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	mchehab+huawei@...nel.org, roberto.sassu@...wei.com, shiju.jose@...wei.com, 
	prime.zeng@...ilicon.com, linuxarm@...wei.com
Subject: Re: [PATCH v3] acpi: Fix HED module initialization order when it is built-in

On Tue, Jan 21, 2025 at 3:23 AM Xiaofei Tan <tanxiaofei@...wei.com> wrote:
>
>
> 在 2025/1/20 19:04, Jonathan Cameron 写道:
> > On Fri, 17 Jan 2025 10:29:57 +0800
> > Xiaofei Tan <tanxiaofei@...wei.com> wrote:
> >
> >> When the module HED is built-in, the module HED init is behind EVGED
> >> as the driver are in the same initcall level, then the order is determined
> >> by Makefile order. That order violates expectations. Because RAS records
> >> can't be handled in the special time window that EVGED has initialized
> >> while HED not.
> >>
> >> If the number of such RAS records is more than the APEI HEST error source
> >> number, the HEST resources could be occupied all, and then could affect
> >> subsequent RAS error reporting.
> >>
> >> Change the initcall level of HED to subsys_init to fix the issue. If build
> >> HED as a module, the problem remains. To solve this problem completely,
> >> change the ACPI_HED from tristate to bool.
> >>
> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> > Given the change in approach (even though I reviewed this internally)
> > should probably have dropped my RB.   Anyhow, consider this me
> > giving it again on list.
> OK. thanks.

Applied as 6.14-rc material with a rewritten changelog and under a new
subject: "ACPI: HED: Always initialize before evged".

Thanks!