linux-kernel - Re: [PATCH v4 4/4] net: mdio: Add RTL9300 MDIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9f68f90-7c30-46b5-aed9-2ca1994494cf@alliedtelesis.co.nz>
Date: Thu, 23 Jan 2025 03:47:14 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Andrew Lunn <andrew@...n.ch>
CC: Sander Vanheule <sander@...nheule.net>, "lee@...nel.org" <lee@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"tsbogend@...ha.franken.de" <tsbogend@...ha.franken.de>,
	"hkallweit1@...il.com" <hkallweit1@...il.com>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "markus.stockhausen@....de"
	<markus.stockhausen@....de>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-mips@...r.kernel.org"
	<linux-mips@...r.kernel.org>
Subject: Re: [PATCH v4 4/4] net: mdio: Add RTL9300 MDIO driver


On 23/01/2025 16:41, Andrew Lunn wrote:
> On Wed, Jan 22, 2025 at 11:02:14PM +0000, Chris Packham wrote:
>> Hi Andrew,
>>
>> On 23/01/2025 10:47, Andrew Lunn wrote:
>>>> I believe the POLL_SEL configuration actually affects an internal port
>>>> polling unit. From the datasheets I have it seems pretty configurable, you
>>>> can tell it which phy registers to poll and what values indicate link
>>>> up/down (the defaults are conveniently setup to match the Realtek PHYs).
>>> You need to disable this. The linux PHY driver is driving the PHY, and
>>> the hardware has no idea what Linux is doing. Say the driver has
>>> changed the page to read a temperature sensor, when the switch does a
>>> poll. Rather than reading the link status, it gets some random value
>>> from the page containing the temperature sensor.
>> There's a mask that can be set via a register that can disable polling
>> for a port. The trick will be deciding when to do so.
> On probe. And leave is disabled. phylink will provide you with all the
> information you need about link up, what the link speed is etc. There
> is no need for PPU.

Works for me :P.