linux-kernel - Re: [GIT PULL] CRC updates for 6.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250123212213.GC88607@sol.localdomain>
Date: Thu, 23 Jan 2025 13:22:13 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Theodore Ts'o <tytso@....edu>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
	Chao Yu <chao@...nel.org>, "Darrick J. Wong" <djwong@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Kent Overstreet <kent.overstreet@...ux.dev>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Vinicius Peixoto <vpeixoto@...amp.dev>,
	WangYuli <wangyuli@...sls0nwwnnilyahiblcmlmlcaoki5s.yundunwaf1.com>
Subject: Re: [GIT PULL] CRC updates for 6.14

On Thu, Jan 23, 2025 at 01:16:57PM -0800, Linus Torvalds wrote:
> On Thu, 23 Jan 2025 at 13:13, Eric Biggers <ebiggers@...nel.org> wrote:
> >
> > x86 unfortunately only has an instruction for crc32c
> 
> Yeah, but isn't that like 90% of the uses?
> 
> IOW, if you'd make the "select" statements a bit more specific, and
> make ext4 (and others) do "select CRC32C" instead, the other ones
> wouldn't even get selected?
> 
>               Linus

There's quite a lot unfortunately.  Try this which finds the regular crc32 (not
crc32c):

    git grep -E '\<(crc32|crc32_le|__crc32_le)\(|"crc32"'

- Eric