linux-kernel - Re: [PATCH] hwmom/applesmc: add imacpro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe34a39f-66aa-4dc1-bf8a-860f57592087@roeck-us.net>
Date: Wed, 22 Jan 2025 20:14:24 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Atharva Tiwari <evepolonium@...il.com>
Cc: Henrik Rydberg <rydberg@...math.org>, Jean Delvare <jdelvare@...e.com>,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmom/applesmc: add imacpro

On 1/21/25 04:31, Atharva Tiwari wrote:
> this patch adds the iMacPro to the whitelist
> as one iMacPro has been released (iMacPro 1,1)
> 
> thanks
> 

 From Documentation/process/submitting-patches.rst:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour.
"

Also, "thanks" is not part of a patch description. For details on how
to write a patch description please see "Describe your changes" in above
referenced document.

Guenter

> Signed-off-by: Atharva Tiwari <evepolonium@...il.com>
> ---
>   drivers/hwmon/applesmc.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index 7964b0e0c5e8..20e390d595e0 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
> @@ -1373,6 +1373,10 @@ static const struct dmi_system_id applesmc_whitelist[] __initconst = {
>   	  DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>   	  DMI_MATCH(DMI_PRODUCT_NAME, "iMac") },
>   	},
> +	{ applesmc_dmi_match, "Apple iMacPro", {
> +	  DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> +	  DMI_MATCH(DMI_PRODUCT_NAME, "iMacPro") },
> +	},
>   	{ applesmc_dmi_match, "Apple Xserve", {
>   	  DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>   	  DMI_MATCH(DMI_PRODUCT_NAME, "Xserve") },