linux-kernel - Re: [PATCH] ASoC: soc-core: Stop using of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zfjhkupa.wl-kuninori.morimoto.gx@renesas.com>
Date: Thu, 23 Jan 2025 22:54:11 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Rob Herring <robh@...nel.org>,
	linux-sound@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: soc-core: Stop using of_property_read_bool() for non-boolean properties


Hi Geert, Mark

> >         ret = of_property_read_u32(np, "dai-tdm-slot-num", &val);
> > -       if (ret && ret != -EINVAL)
> > -               return ret;
> >         if (!ret && slots)
> >                 *slots = val;
(snip)
> That would be a change in behavior. Probably it would be fine for
> existing users, though, as no existing DTS should cause these errors,
> else sound wouldn't work.  For a new DTS, it would silently ignore errors.
> You are in a better position to make that decision, though.

Thanks
I will post that patch if Gerrt's patch was applied.

> BTW, is there any specific reason the code always checks for the
> presence of "dai-tdm-slot-num", even if slots is NULL, and the result
> sn't used? I.e. would
> 
>     if (slots) {
>             ret = of_property_read_u32(np, "dai-tdm-slot-num", &val);
>             if (!ret)
>                     *slots = val;
>             else if (ret != -EINVAL)
>                     return ret;
>     }

I'm not 100% sure, but -num is used by the driver which can select the
number of TDM. Some driver uses default / fixed number. And -width too.
So I think these can be independent.


Thank you for your help !!

Best regards
---
Kuninori Morimoto