linux-kernel - Re: [PATCH v5 05/10] dt-bindings: media: Add amlogic,c3-isp.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d61cffd-fe5e-440a-ad40-56e0c5fd2358@kernel.org>
Date: Thu, 23 Jan 2025 08:23:17 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jacopo Mondi <jacopo.mondi@...asonboard.com>
Cc: keke.li@...ogic.com, Mauro Carvalho Chehab <mchehab@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 kieran.bingham@...asonboard.com, laurent.pinchart@...asonboard.com,
 dan.scally@...asonboard.com
Subject: Re: [PATCH v5 05/10] dt-bindings: media: Add amlogic,c3-isp.yaml

On 22/01/2025 14:38, Jacopo Mondi wrote:
> On Fri, Dec 27, 2024 at 08:22:22AM +0100, Krzysztof Kozlowski wrote:
>> On 27/12/2024 08:09, Keke Li via B4 Relay wrote:
>>> +
>>> +  clocks:
>>> +    maxItems: 2
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: vapb
>>> +      - const: isp0
>>> +
>>> +  assigned-clocks: true
>>> +
>>> +  assigned-clock-rates: true
>>
>> No, drop these. Request re-review if you add new properties.
> 
> Why ?
> 
> I think the patches should be re-checked and it's fair to ask to drop
> the rb tag.

So I asked.

> But the idea that patches once reviewed should not be
> modified between two different versions of the same set seems really..
> debatable ?
No one said that. If you want to modify, no problem, but drop the tag.
You cannot sneak new properties while keeping the review tag.


Best regards,
Krzysztof