linux-kernel - Re: [PATCH v2 1/8] scsi: ufs: core: Pass target_freq to clk_scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3a0b0b1-f4a8-4285-96de-8ce2633c7918@quicinc.com>
Date: Thu, 23 Jan 2025 15:37:48 +0800
From: Ziqi Chen <quic_ziqichen@...cinc.com>
To: Bart Van Assche <bvanassche@....org>, <quic_cang@...cinc.com>,
        <mani@...nel.org>, <beanhuo@...ron.com>, <avri.altman@....com>,
        <junwoo80.lee@...sung.com>, <martin.petersen@...cle.com>,
        <quic_nguyenb@...cinc.com>, <quic_nitirawa@...cinc.com>,
        <quic_rampraka@...cinc.com>
CC: <linux-arm-msm@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        Alim Akhtar
	<alim.akhtar@...sung.com>,
        "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>,
        Peter Wang
	<peter.wang@...iatek.com>,
        Stanley Jhu <chu.stanley@...il.com>,
        "Manivannan
 Sadhasivam" <manivannan.sadhasivam@...aro.org>,
        Matthias Brugger
	<matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
        Andrew Halaney
	<ahalaney@...hat.com>,
        Maramaina Naresh <quic_mnaresh@...cinc.com>,
        "Eric
 Biggers" <ebiggers@...gle.com>,
        Minwoo Im <minwoo.im@...sung.com>,
        open list
	<linux-kernel@...r.kernel.org>,
        "moderated list:UNIVERSAL FLASH STORAGE HOST
 CONTROLLER DRIVER..." <linux-mediatek@...ts.infradead.org>,
        "moderated
 list:ARM/Mediatek SoC support:Keyword:mediatek"
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/8] scsi: ufs: core: Pass target_freq to
 clk_scale_notify() vops



On 1/23/2025 2:19 AM, Bart Van Assche wrote:
> On 1/22/25 2:02 AM, Ziqi Chen wrote:
>> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
>> index d7aca9e61684..a4dac897a169 100644
>> --- a/include/ufs/ufshcd.h
>> +++ b/include/ufs/ufshcd.h
>> @@ -344,7 +344,7 @@ struct ufs_hba_variant_ops {
>>       void    (*exit)(struct ufs_hba *);
>>       u32    (*get_ufs_hci_version)(struct ufs_hba *);
>>       int    (*set_dma_mask)(struct ufs_hba *);
>> -    int    (*clk_scale_notify)(struct ufs_hba *, bool,
>> +    int (*clk_scale_notify)(struct ufs_hba *, bool, unsigned long,
>>                       enum ufs_notify_change_status);
>>       int    (*setup_clocks)(struct ufs_hba *, bool,
>>                   enum ufs_notify_change_status);
> 
> Please keep the indentation consistent.
> 
> Thanks,
> 
> Bart.

Thanks, Bart, I will improve it.

-Ziqi