linux-kernel - Re: [RESEND] PCI: cadence: Add configuration space capability search API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vj5skjgz4li2vit3xpr3ysldrcvzoglfycemki3yrzg4ocrrkc@isk7ytysgih7>
Date: Thu, 23 Jan 2025 13:10:49 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Hans Zhang <18255117159@....com>
CC: <lpieralisi@...nel.org>, <kw@...ux.com>,
        <manivannan.sadhasivam@...aro.org>, <robh@...nel.org>,
        <bhelgaas@...gle.com>, <bwawrzyn@...co.com>, <s-vadapalli@...com>,
        <thomas.richard@...tlin.com>,
        <wojciech.jasko-EXT@...tinental-corporation.com>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND] PCI: cadence: Add configuration space capability search
 API

On Thu, Jan 23, 2025 at 03:09:35PM +0800, Hans Zhang wrote:
> Add configuration space capability search API using struct cdns_pcie*
> pointer.
> 
> Similar patches below have been merged.
> commit 5b0841fa653f ("PCI: dwc: Add extended configuration space capability
> search API")
> commit 7a6854f6874f ("PCI: dwc: Move config space capability search API")

Similar patches being merged doesn't sound like a proper reason for
having a feature. Please provide details regarding why this is required.
Assuming that the intent for introducing this feature is to use it
later, it will be a good idea to post the patch for that as well in the
same series.

> 
> Signed-off-by: Hans Zhang <18255117159@....com>
> ---
>  drivers/pci/controller/cadence/pcie-cadence.c | 80 +++++++++++++++++++
>  drivers/pci/controller/cadence/pcie-cadence.h |  3 +
>  2 files changed, 83 insertions(+)

[...]

Regards,
Siddharth.