linux-kernel - Re: [PATCH v7 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250123-stereotyped-chupacabra-of-mathematics-10d9ce@krzk-bin>
Date: Thu, 23 Jan 2025 09:27:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com, 
	manivannan.sadhasivam@...aro.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	vkoul@...nel.org, kishon@...nel.org, andersson@...nel.org, konradybcio@...nel.org, 
	p.zabel@...gutronix.de, dmitry.baryshkov@...aro.org, quic_nsekar@...cinc.com, 
	linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v7 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe
 controller

On Thu, Jan 23, 2025 at 01:35:36PM +0530, Varadarajan Narayanan wrote:
> On Thu, Jan 23, 2025 at 08:58:29AM +0100, Krzysztof Kozlowski wrote:
> > On Wed, Jan 22, 2025 at 12:04:09PM +0530, Varadarajan Narayanan wrote:
> > > Document the PCIe controller on IPQ5332 platform. IPQ5332 will
> > > use IPQ9574 as the fall back compatible.
> > >
> > > Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> > > ---
> > > v7: Moved ipq9574 related changes to a separate patch
> > >     Add 'global' interrupt
> > >
> > > v6: Commit message update only. Add info regarding the moving of
> > >     ipq9574 from 5 "reg" definition to 5 or 6 reg definition.
> > >
> > > v5: Re-arrange 5332 and 9574 compatibles to handle fallback usage in dts
> > >
> > > v4: * v3 reused ipq9574 bindings for ipq5332. Instead add one for ipq5332
> > >     * DTS uses ipq9574 compatible as fallback. Hence move ipq9574 to be able
> > >       to use the 'reg' section for both ipq5332 and ipq9574. Else, dtbs_check
> > >       and dt_binding_check flag errors.
> > > ---
> > >  .../devicetree/bindings/pci/qcom,pcie.yaml          | 13 +++++++++++--
> > >  1 file changed, 11 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > > index 413c6b76c26c..ead97286fd41 100644
> > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > > @@ -34,6 +34,10 @@ properties:
> > >        - items:
> > >            - const: qcom,pcie-msm8998
> > >            - const: qcom,pcie-msm8996
> > > +      - items:
> > > +          - enum:
> > > +              - qcom,pcie-ipq5332
> > > +          - const: qcom,pcie-ipq9574
> >
> > Repeated many times on reviews to qcom: don't add to the end of the
> > lists. In case of multiple items, these are ordered by fallback, so this
> > goes next to other ipq entry... wait, that's already qcom,pcie-ipq9574,
> > so why are you duplicating?
> >
> > On what tree are you working?
> 
> Looks like ipq5424 changes got merged between the time I cloned
> linux-next, tested and posted the patch. Will fix this and post
> a new one.

Yeah, that would explain. Please grow the enum instead.

Best regards,
Krzysztof