linux-kernel - Re: [PATCH] documentation: networking: fix spelling mistakes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69da3515-13c8-4626-a2b8-cce7c625da43@intel.com>
Date: Thu, 23 Jan 2025 10:12:22 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Khaled Elnaggar <khaledelnaggarlinux@...il.com>
CC: <shuah@...nel.org>, <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-kernel-mentees@...r.kernel.org>, <socketcan@...tkopp.net>,
	<mkl@...gutronix.de>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>, <corbet@....net>
Subject: Re: [PATCH] documentation: networking: fix spelling mistakes

On 1/23/25 09:25, Khaled Elnaggar wrote:
> Fix a couple of typos/spelling mistakes in the documentation.
> 
> Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@...il.com>
> ---
> Hello, I hope the patch is self-explanatory. Please let me know if you
> have any comments.

looks good, also process wise, also this comment is properly put

(one thing to possibly improve would be to put "net" as the target in
the subject (see other patches on the netdev mailing list); for
non-fixes it would be "net-next"; but don't resubmit just for that)

I'm assuming you have fixed all the typos in that two files, with that:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

> 
> Aside: CCing Shuah and linux-kernel-mentees as I am working on the mentorship
> application tasks.
> 
> Thanks
> Khaled
> ---
>   Documentation/networking/can.rst  | 4 ++--
>   Documentation/networking/napi.rst | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/can.rst b/Documentation/networking/can.rst
> index 62519d38c58b..b018ce346392 100644
> --- a/Documentation/networking/can.rst
> +++ b/Documentation/networking/can.rst
> @@ -699,10 +699,10 @@ RAW socket option CAN_RAW_JOIN_FILTERS
> 
>   The CAN_RAW socket can set multiple CAN identifier specific filters that
>   lead to multiple filters in the af_can.c filter processing. These filters
> -are indenpendent from each other which leads to logical OR'ed filters when
> +are independent from each other which leads to logical OR'ed filters when
>   applied (see :ref:`socketcan-rawfilter`).
> 
> -This socket option joines the given CAN filters in the way that only CAN
> +This socket option joins the given CAN filters in the way that only CAN
>   frames are passed to user space that matched *all* given CAN filters. The
>   semantic for the applied filters is therefore changed to a logical AND.
> 
> diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> index 6083210ab2a4..f970a2be271a 100644
> --- a/Documentation/networking/napi.rst
> +++ b/Documentation/networking/napi.rst
> @@ -362,7 +362,7 @@ It is expected that ``irq-suspend-timeout`` will be set to a value much larger
>   than ``gro_flush_timeout`` as ``irq-suspend-timeout`` should suspend IRQs for
>   the duration of one userland processing cycle.
> 
> -While it is not stricly necessary to use ``napi_defer_hard_irqs`` and
> +While it is not strictly necessary to use ``napi_defer_hard_irqs`` and
>   ``gro_flush_timeout`` to use IRQ suspension, their use is strongly
>   recommended.
> 
> --
> 2.45.2
> 
>