linux-kernel - Re: [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for Yuridenki-Shokai Kakip board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdW_UjGD5QQ87m6kC_Ei9LOdA6=T6zsmp3HL7Y_t0SP7QQ@mail.gmail.com>
Date: Thu, 23 Jan 2025 11:58:16 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Nobuhiro Iwamatsu <iwamatsu@...auri.org>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Masato Kiuchi <kiuchi_masato@...idenki.co.jp>
Subject: Re: [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for
 Yuridenki-Shokai Kakip board

Hi Iwamatsu-san,

On Thu, Jan 16, 2025 at 3:48 PM Nobuhiro Iwamatsu <iwamatsu@...auri.org> wrote:
> Add basic support for Yuridenki-Shokai Kakip board based on R9A09G057H48.
> This commit supports the following:
>
>   - Memory
>   - Input clocks
>   - Pin Control
>   - SCIF
>   - OSTM0 - OSTM7
>   - SDHI0
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@...auri.org>
>
> ---
> v2: Drop bootargs from chosen.
>     Fix binding name for regulators.
>     Fix the name style of the regulator.
>     Use DTS coding style.

Thanks for the update!

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts

> +/ {

> +       vqmmc_sdhi0: regulator-vccq-sdhi0 {
> +               compatible = "regulator-gpio";
> +               regulator-name = "SDHI0 VccQ";
> +               gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
> +               regulator-min-microvolt = <1800000>;
> +               regulator-max-microvolt = <3300000>;
> +               gpios-states = <0>;
> +               states = <3300000 0 1800000 1>;

"states = <3300000 0>, <1800000 1>;", as these are two tuples.

> +       };
> +};
> +
> +&qextal_clk {
> +       clock-frequency = <24000000>;
> +};
> +
> +&pinctrl {

Please sort nodes alphabetically.

> +&scif {

> +};
> +
> +&ostm0 {

Likewise.

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v6.15, with the above fixed.
No need to resend.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds