linux-kernel - Re: [PATCH] firmware: arm_scmi: imx: Correct tx size of scmi_imx_misc_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5I0Irl1eUarzLlA@bogus>
Date: Thu, 23 Jan 2025 12:20:50 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: <cristian.marussi@....com>, <arm-scmi@...r.kernel.org>,
	Sudeep Holla <sudeep.holla@....com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, Peng Fan <peng.fan@....com>,
	Jacky Bai <ping.bai@....com>, Shengjiu Wang <shengjiu.wang@....com>,
	Jason Liu <jason.hui.liu@....com>
Subject: Re: [PATCH] firmware: arm_scmi: imx: Correct tx size of
 scmi_imx_misc_ctrl_set

On Thu, Jan 23, 2025 at 02:34:41PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> 'struct scmi_imx_misc_ctrl_set_in' has a zero length array in the end,
> so sizeof will not count 'value[]', and txsize is smaller than actual
> size for tx,and SCMI firmware will take this protocol error.
> 
> Fix this by enlarge the txsize with 'num * 4' to count in the size of
> data.
> 
> Fixes: 61c9f03e22fc ("firmware: arm_scmi: Add initial support for i.MX MISC protocol")
> Reviewed-by: Jacky Bai <ping.bai@....com>
> Tested-by: Shengjiu Wang <shengjiu.wang@....com>
> Acked-by: Jason Liu <jason.hui.liu@....com>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> 
> V1:
>  Patch is cherry-picked from downstream, so tags are kept.
>

I don't if Ack is really helpful, but Tested-by is as we can't test it
on any other platform. But it would be better if provided on the list
instead of coming pre-packaged like this in the future. I will add it
as fix soon. Thanks!

-- 
Regards,
Sudeep