linux-kernel - Re: [PATCH 2/4] ASoC: SOF: imx: Add mach entry to select cs42888 topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5Jif6CjuSaXfWSA@lizhi-Precision-Tower-5810>
Date: Thu, 23 Jan 2025 10:38:39 -0500
From: Frank Li <Frank.li@....com>
To: Daniel Baluta <daniel.baluta@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, robh@...nel.org,
	krzk+dt@...nel.org, broonie@...nel.org, shawnguo@...nel.org,
	conor+dt@...nel.org, peng.fan@....com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, lgirdwood@...il.com,
	peter.ujfalusi@...ux.intel.com, linux-sound@...r.kernel.org,
	imx@...ts.linux.dev, Liam Girdwood <liam.r.girdwood@...el.com>,
	Bard Liao <yung-chuan.liao@...ux.intel.com>,
	Iuliana Prodan <iuliana.prodan@....com>,
	Laurentiu Mihalcea <laurentiu.mihalcea@....com>
Subject: Re: [PATCH 2/4] ASoC: SOF: imx: Add mach entry to select cs42888
 topology

On Thu, Jan 23, 2025 at 11:38:33AM +0200, Daniel Baluta wrote:
> On Wed, Jan 22, 2025 at 9:55 PM Frank Li <Frank.li@....com> wrote:
> >
> > On Wed, Jan 22, 2025 at 06:35:42PM +0200, Daniel Baluta wrote:
> > > After commit 2b9cdef13648 ("ASoC: SOF: imx: Add devicetree support
> > > to select topologies") we select topology to be used by the board
> > > compatible string in the dts.
> >
> > I am confused. why not use "sof-imx8-cs42888.tplg" in imx8's dts instead
> > use board's compatible string "fsl,imx8qxp-mek-bb".
> >
> > More and more boards will be added in future. This file will become bigger
> > and bigger!
>
> Hi Frank,
>
> So you mean create a dts property named e.g sof-tplg-name and read the
> topology name from dts?
>
> dsp {
>        firmware-name="sof-imx8.ri";
>        tplg-name = "sof-imx8-cs428888.tplg";
> };

  dsp {
	compatible = "imx8-dsp-xxxx";
	...
  }

in dsp driver, map "imx8-dsp-xxxx" to "sof-imx8-cs428888.tplg" and
"sof-imx8.ri".

>
>
> This was our first approach but then we aligned with the community on
> using compatible to match
> for properties like default fw path, default tplg path, fw name, tplg name.

What's origial email thread. I think "compatible" refer to dsp node, not
to boards level compatible string.

>
> Now dts should somehow describe the hardware not the software (e.g
> tplg binary) used on that platform.
> The growing number of boards will not be a problem, each one will have
> a compatible in the dts.

Yes, but your C files will fill up meansless map code when more board
added.


>
> But the concern here is how we describe a hardware setup where we have
> a CPU board + a baseboard
> like it is the case for cs42888 codec?
>
> Our approach was that in our dts or overlay dts that describes SOF
> with cs428888 codec to put the exact
> compatible "fsl,imx8qxp-mek-bb" and match it with static vector in SOF
> driver that you see in this patch.
>
> SOF core relies on the compatible string in order to identify the
> correct tplg_filename for example.

Any application ctrl tools can link these nodes?

Frank

>
> thanks,
> Daniel.