linux-kernel - Re: [RESEND PATCH 1/3] x86/mce/inject: Remova call to mce_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f0ca15c-7d6e-4274-ae4c-20f55340aad6@suse.com>
Date: Thu, 23 Jan 2025 18:00:59 +0200
From: Nikolay Borisov <nik.borisov@...e.com>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: linux-edac@...r.kernel.org, x86@...nel.org, linux-kernel@...r.kernel.org,
 bp@...en8.de
Subject: Re: [RESEND PATCH 1/3] x86/mce/inject: Remova call to
 mce_notify_irq()



On 22.01.25 г. 20:24 ч., Yazen Ghannam wrote:
> On Wed, Jan 15, 2025 at 09:36:38AM +0200, Nikolay Borisov wrote:
> 
> Hi Nikolay,
> 
> There is a typo in the $SUBJECT.
> 
>> The call is actually a noop because when the MCE is raised the early
>> notifier is the only call site that correctly calls mce_notify_irq()
>> because it also sets mce_need_notify. So let's just remove this call,
>> which allows to unexport mce_notify_irq.
>>
> 
> The commit message should be in passive and imperative voice.
> 
> "So let's just remove this..." -> "Remove this..."
> 
>> Signed-off-by: Nikolay Borisov <nik.borisov@...e.com>
>> ---
>>   arch/x86/kernel/cpu/mce/core.c   | 1 -
>>   arch/x86/kernel/cpu/mce/inject.c | 1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
>> index 0dc00c9894c7..23e5e7f7c554 100644
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> @@ -1793,7 +1793,6 @@ bool mce_notify_irq(void)
>>   	}
>>   	return false;
>>   }
>> -EXPORT_SYMBOL_GPL(mce_notify_irq);
>>
>>   static void __mcheck_cpu_mce_banks_init(void)
>>   {
>> diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c
>> index 313fe682db33..06e3cf7229ce 100644
>> --- a/arch/x86/kernel/cpu/mce/inject.c
>> +++ b/arch/x86/kernel/cpu/mce/inject.c
>> @@ -229,7 +229,6 @@ static int raise_local(void)
>>   	} else if (m->status) {
>>   		pr_info("Starting machine check poll CPU %d\n", cpu);
>>   		raise_poll(m);
>> -		mce_notify_irq();
> 
> With this change, there are no users of mce_notify_irq() outside of
> mce/core.c. So you could go further and make the function static to
> core.c.
> 
> In other words, you could squash the second patch into this one.

Thanks, I've incorporated those in V2 that I sent.

> 
> Thanks,
> Yazen