linux-kernel - Re: [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and read in soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbee969d-7464-497a-a98b-4e6055176fbc@lunn.ch>
Date: Thu, 23 Jan 2025 17:26:07 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Milos Reljin <milos_reljin@...look.com>
Cc: andrei.botila@....nxp.com, hkallweit1@...il.com, linux@...linux.org.uk,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, milos.reljin@...rk.com
Subject: Re: [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and
 read in soft_reset

On Thu, Jan 23, 2025 at 03:43:46PM +0000, Milos Reljin wrote:
> In application note (AN13663) for TJA1120, on page 30, there's a figure
> with average PHY startup timing values following software reset.
> The time it takes for SMI to become operational after software reset
> ranges roughly from 500 us to 1500 us.
> 
> This commit adds 2000 us delay after MDIO write which triggers software
> reset. Without this delay, soft_reset function returns an error and
> prevents successful PHY init.

Is this a fix? Should it be backported to stable? If so:

Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103")

and it should really indicate the net tree in the Subject: line.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Otherwise the patch looks good. Thanks for the updated commit message.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew