linux-kernel - [PATCH net v2 2/2] net: sh_eth: Fix missing rtnl lock in suspend path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250123-fix_missing_rtnl_lock_phy_disconnect-v2-2-e6206f5508ba@bootlin.com>
Date: Thu, 23 Jan 2025 17:58:01 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Paul Barker <paul.barker.ct@...renesas.com>, 
 Niklas Söderlund <niklas.soderlund@...natech.se>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
 Mikhail Ulyanov <mikhail.ulyanov@...entembedded.com>, 
 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 Niklas Söderlund <niklas.soderlund+renesas@...natech.se>, 
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>, netdev@...r.kernel.org, 
 linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Kory Maincent <kory.maincent@...tlin.com>, 
 Sergey Shtylyov <s.shtylyov@....ru>
Subject: [PATCH net v2 2/2] net: sh_eth: Fix missing rtnl lock in suspend
 path

Fix the suspend path by ensuring the rtnl lock is held where required.
Calls to sh_eth_close, sh_eth_open and wol operations must be performed
under the rtnl lock to prevent conflicts with ongoing ndo operations.

Fixes: b71af04676e9 ("sh_eth: add more PM methods")
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
---
 drivers/net/ethernet/renesas/sh_eth.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 8887b8921009..5fc8027c92c7 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3494,10 +3494,12 @@ static int sh_eth_suspend(struct device *dev)

 	netif_device_detach(ndev);

+	rtnl_lock();
 	if (mdp->wol_enabled)
 		ret = sh_eth_wol_setup(ndev);
 	else
 		ret = sh_eth_close(ndev);
+	rtnl_unlock();

 	return ret;
 }
@@ -3511,10 +3513,12 @@ static int sh_eth_resume(struct device *dev)
 	if (!netif_running(ndev))
 		return 0;

+	rtnl_lock();
 	if (mdp->wol_enabled)
 		ret = sh_eth_wol_restore(ndev);
 	else
 		ret = sh_eth_open(ndev);
+	rtnl_unlock();

 	if (ret < 0)
 		return ret;

-- 
2.34.1