linux-kernel - Re: [PATCH v5 3/3] selftests/lam: Test get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <big3a7ce3exdujixvnfxp4aovroqqrttbncu437nlgkexatj5q@slwamyheegki>
Date: Fri, 24 Jan 2025 21:19:43 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
To: Dave Hansen <dave.hansen@...el.com>
CC: <shuah@...nel.org>, <hpa@...or.com>, <x86@...nel.org>,
	<dave.hansen@...ux.intel.com>, <bp@...en8.de>, <mingo@...hat.com>,
	<tglx@...utronix.de>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <kirill@...temov.name>, "Kirill A.
 Shutemov" <kirill.shutemov@...ux.intel.com>, Shuah Khan
	<skhan@...uxfoundation.org>
Subject: Re: [PATCH v5 3/3] selftests/lam: Test get_user() LAM pointer
 handling

On 2025-01-24 at 08:32:18 -0800, Dave Hansen wrote:
>On 11/27/24 09:35, Maciej Wieczor-Retman wrote:
>...
>> +	switch (test->later) {
>> +	case GET_USER_USER:
>> +		/* Control group - properly tagger user pointer */
>> +		ptr = (void *)set_metadata((uint64_t)ptr, test->lam);
>> +		break;
>
>s/tagger/tagged/ ?

Thanks!

>
>> +	default:
>> +		printf("Invalid test case value passed!\n");
>> +		break;
>> +	}
>> +
>> +	if (ioctl(fd, FIOASYNC, ptr) != 0)
>> +		ret = 1;
>> +
>> +	close(fd);
>> +error:
>> +	munmap(ptr, PAGE_SIZE);
>> +	return ret;
>> +}
>
>I'd really prefer that the theory of operation be in a code comment and
>not just in the changelog.

Sure, I'll comment the ioctl() usage so it's more clear what's happening.

-- 
Kind regards
Maciej Wieczór-Retman