linux-kernel - Re: [PATCH v2] cpuidle: psci: Add trace for PSCI domain idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250124152824.292985bf@gandalf.local.home>
Date: Fri, 24 Jan 2025 15:28:24 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Keita Morisaki <keyz@...gle.com>
Cc: mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 lpieralisi@...nel.org, sudeep.holla@....com, rafael@...nel.org,
 daniel.lezcano@...aro.org, linux-pm@...r.kernel.org, aarontian@...gle.com,
 yimingtseng@...gle.com
Subject: Re: [PATCH v2] cpuidle: psci: Add trace for PSCI domain idle

On Mon, 20 Jan 2025 09:36:16 +0800
Keita Morisaki <keyz@...gle.com> wrote:

> The trace event cpu_idle provides insufficient information for debugging
> PSCI requests due to lacking access to determined PSCI domain idle
> states. The cpu_idle usually only shows -1, 0, or 1 regardless how many
> idle states the power domain has.
> 
> Add new trace events namely psci_domain_idle_enter and
> psci_domain_idle_exit to trace enter and exit events with a determined
> idle state.
> 
> These new trace events will help developers debug CPUidle issues on ARM
> systems using PSCI by providing more detailed information about the
> requested idle states.
> 
> Signed-off-by: Keita Morisaki <keyz@...gle.com>
> ---
> v1->v2: Split the ftrace event into two (psci_domain_idle_(enter|exit))
> 		and rephrase the commit message accordingly. Rebased onto the latest.
> 
>  drivers/cpuidle/cpuidle-psci.c |  3 +++
>  include/trace/events/power.h   | 37 ++++++++++++++++++++++++++++++++++
>  2 files changed, 40 insertions(+)

From the tracing point of view, there's nothing that sticks out that is incorrect.

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

As for if it should be applied, that's for the maintainers of the subsystem
that it exists in.

-- Steve