linux-kernel - Re: [PATCH 1/2] of: address: Fix empty resource handling in __of_address_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173775596409.2511219.13763390679214460358.robh@kernel.org>
Date: Fri, 24 Jan 2025 16:00:05 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Basharath Hussain Khaja <basharath@...thit.com>,
	Saravana Kannan <saravanak@...gle.com>, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] of: address: Fix empty resource handling in
 __of_address_resource_bounds()


On Mon, 20 Jan 2025 15:09:40 +0100, Thomas Weißschuh wrote:
> "resource->end" needs to always be equal to "resource->start + size - 1".
> The previous version of the function did not perform the "- 1" in case
> of an empty resource.
> 
> Also make sure to allow an empty resource at address 0.
> 
> Reported-by: Basharath Hussain Khaja <basharath@...thit.com>
> Closes: https://lore.kernel.org/lkml/20250108140414.13530-1-basharath@couthit.com/
> Fixes: 1a52a094c2f0 ("of: address: Unify resource bounds overflow checking")
> Cc: stable@...r.kernel.org
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
>  drivers/of/address.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 

Applied, thanks!

Please resend the kunit test with 0-day issues fixed.

Rob