linux-kernel - Re: [PATCH] mux: mmio: Do not use syscon helper to build regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250124221604.dgzm72fstf625cik@dismount>
Date: Fri, 24 Jan 2025 16:16:04 -0600
From: Nishanth Menon <nm@...com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Andrew Davis <afd@...com>, Peter Rosin <peda@...ntia.se>,
        Vignesh
 Raghavendra <vigneshr@...com>, <linux-kernel@...r.kernel.org>,
        "Rob Herring
 (Arm)" <robh@...nel.org>, Lee Jones <lee@...nel.org>
Subject: Re: [PATCH] mux: mmio: Do not use syscon helper to build regmap

On 06:26-20250124, Greg Kroah-Hartman wrote:
> On Thu, Jan 23, 2025 at 02:04:12PM -0600, Nishanth Menon wrote:
> > On 12:20-20250123, Andrew Davis wrote:
> > > The syscon helper device_node_to_regmap() is used to fetch a regmap
> > > registered to a device node. It also currently creates this regmap
> > > if the node did not already have a regmap associated with it. This
> > > should only be used on "syscon" nodes. This driver is not such a
> > > device and instead uses device_node_to_regmap() on its own node as
> > > a hacky way to create a regmap for itself.
> > > 
> > > This will not work going forward and so we should create our regmap
> > > the normal way by defining our regmap_config, fetching our memory
> > > resource, then using the normal regmap_init_mmio() function.
> > > 
> > > Signed-off-by: Andrew Davis <afd@...com>
> > > ---
> > Tested-by: Nishanth Menon <nm@...com>
> > 
> > Greg, Peter,
> > 
> > This is part of the fixes TI K3 platforms boot issues reported in
> > https://lore.kernel.org/all/b2413460-ec8b-4c77-99b8-4c32b262439a@ti.com/
> > on the latest linus master v6.13-5001-gd0d106a2bd21 + linux
> > next-20250123
> > 
> > Total set of patches tested with:
> > https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/
> > https://lore.kernel.org/r/20250123181726.597144-1-afd@ti.com
> > https://lore.kernel.org/r/20250123181913.597304-1-afd@ti.com
> > https://lore.kernel.org/r/20250123182059.597491-1-afd@ti.com
> > https://lore.kernel.org/r/20250123182234.597665-1-afd@ti.com
> > 
> > Could we get this routed to master as fixes asap please to get a sane 6.14?
> 
> Our trees are of course closed right now due to the merge window, you
> know that :)
> 
> So we can take things after -rc1 is out, and route bugfixes for
> 6.14-final and new stuff for 6.15-rc1, like always.  It's hard to see
> that this is just a bugfix, but if it is, it needs a Fixes: tag at the
> very least, right?

Just following up after a bit of discussion on IRC.. (Thanks Rob)

I think getting this patch in current window is less urgent for given
Rob has posted a restoration of behavior[1]. This patch is still
good to be merged based on [2], but probably queued as appropriate.

[1] https://lore.kernel.org/all/20250124191644.2309790-1-robh@kernel.org/
[2] https://lore.kernel.org/all/CAL_JsqKVydDqmr-gyn1wt=1PO_p1NMze+1D+4qXWxGiGVLV9EA@mail.gmail.com/

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D