linux-kernel - Re: [net-next PATCH v4 3/6] octeontx2-pf: AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202501241139.g1v0lH4V-lkp@intel.com>
Date: Fri, 24 Jan 2025 12:10:17 +0800
From: kernel test robot <lkp@...el.com>
To: Suman Ghosh <sumang@...vell.com>, horms@...nel.org,
	sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
	hkelam@...vell.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lcherian@...vell.com,
	jerinj@...vell.com, john.fastabend@...il.com, bbhushan2@...vell.com,
	hawk@...nel.org, andrew+netdev@...n.ch, ast@...nel.org,
	daniel@...earbox.net, bpf@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Suman Ghosh <sumang@...vell.com>
Subject: Re: [net-next PATCH v4 3/6] octeontx2-pf: AF_XDP zero copy receive
 support

Hi Suman,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Suman-Ghosh/octeontx2-pf-Don-t-unmap-page-pool-buffer/20250117-031510
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250116191116.3357181-4-sumang%40marvell.com
patch subject: [net-next PATCH v4 3/6] octeontx2-pf: AF_XDP zero copy receive support
config: loongarch-randconfig-001-20250124 (https://download.01.org/0day-ci/archive/20250124/202501241139.g1v0lH4V-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250124/202501241139.g1v0lH4V-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501241139.g1v0lH4V-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c: In function 'otx2_probe':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:3222:1: warning: label 'err_dcbnl_set_ops' defined but not used [-Wunused-label]
    3222 | err_dcbnl_set_ops:
         | ^~~~~~~~~~~~~~~~~


vim +/err_dcbnl_set_ops +3222 drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

  3217	
  3218		otx2_qos_init(pf, qos_txqs);
  3219	
  3220		return 0;
  3221	
> 3222	err_dcbnl_set_ops:
  3223		bitmap_free(pf->af_xdp_zc_qidx);
  3224	err_af_xdp_zc:
  3225		otx2_sriov_vfcfg_cleanup(pf);
  3226	err_pf_sriov_init:
  3227		otx2_shutdown_tc(pf);
  3228	err_mcam_flow_del:
  3229		otx2_mcam_flow_del(pf);
  3230	err_unreg_netdev:
  3231		unregister_netdev(netdev);
  3232	err_ipsec_clean:
  3233		cn10k_ipsec_clean(pf);
  3234	err_mcs_free:
  3235		cn10k_mcs_free(pf);
  3236	err_del_mcam_entries:
  3237		otx2_mcam_flow_del(pf);
  3238	err_ptp_destroy:
  3239		otx2_ptp_destroy(pf);
  3240	err_detach_rsrc:
  3241		if (pf->hw.lmt_info)
  3242			free_percpu(pf->hw.lmt_info);
  3243		if (test_bit(CN10K_LMTST, &pf->hw.cap_flag))
  3244			qmem_free(pf->dev, pf->dync_lmt);
  3245		otx2_detach_resources(&pf->mbox);
  3246		otx2_disable_mbox_intr(pf);
  3247		otx2_pfaf_mbox_destroy(pf);
  3248		pci_free_irq_vectors(hw->pdev);
  3249	err_free_netdev:
  3250		pci_set_drvdata(pdev, NULL);
  3251		free_netdev(netdev);
  3252	err_release_regions:
  3253		pci_release_regions(pdev);
  3254		return err;
  3255	}
  3256	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki