linux-kernel - RE: [PATCH] i2c: imx-lpi2c: select CONFIG_I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM0PR0402MB393773B2F928011CC9DCA2D9E8E32@AM0PR0402MB3937.eurprd04.prod.outlook.com>
Date: Fri, 24 Jan 2025 04:59:56 +0000
From: Carlos Song <carlos.song@....com>
To: Arnd Bergmann <arnd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, Wolfram Sang
	<wsa+renesas@...g-engineering.com>, "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] i2c: imx-lpi2c: select CONFIG_I2C_SLAVE


> From: Arnd Bergmann <arnd@...db.de>
> 
> The addition of target mode causes a build failure when CONFIG_I2C_SLAVE is
> turned off:
> 
> drivers/i2c/busses/i2c-imx-lpi2c.c:1273:10: error: 'const struct i2c_algorithm'
> has no member named 'reg_target'
>  1273 |         .reg_target     = lpi2c_imx_register_target,
>       |          ^~~~~~~~~~
> drivers/i2c/busses/i2c-imx-lpi2c.c:1274:10: error: 'const struct i2c_algorithm'
> has no member named 'unreg_target'
>  1274 |         .unreg_target   = lpi2c_imx_unregister_target,
>       |          ^~~~~~~~~~~~
> 
> Select the Kconfig symbol like we do for other similar drivers.
> 
> Fixes: 1ee867e465c1 ("i2c: imx-lpi2c: add target mode support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/i2c/busses/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index
> 3fb1fa8244fb..60736a2831ba 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -756,6 +756,7 @@ config I2C_IMX
>  config I2C_IMX_LPI2C
>         tristate "IMX Low Power I2C interface"
>         depends on ARCH_MXC || COMPILE_TEST
> +       select I2C_SLAVE
>         help
>           Say Y here if you want to use the Low Power IIC bus controller
>           on the Freescale i.MX processors.
> --

Hi, Arnd

Thank you for very much for your fix!:) 

You may add my ack:
Acked-by: Carlos Song <carlos.song@....com>

Best Regards
Carlos
> 2.39.5