linux-kernel - Re: [PATCH] clk: qcom: ipq5424: fix software and hardware flow control error of UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68f01848-fcea-4849-b355-6479bb1f9fc4@quicinc.com>
Date: Fri, 24 Jan 2025 11:25:06 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
CC: <andersson@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_srichara@...cinc.com>
Subject: Re: [PATCH] clk: qcom: ipq5424: fix software and hardware flow
 control error of UART



On 1/23/2025 6:59 PM, Varadarajan Narayanan wrote:
> On Thu, Jan 23, 2025 at 04:46:18PM +0530, Manikanta Mylavarapu wrote:
>> The UART’s software and hardware flow control are currently not
>> functioning correctly.
>>
>> For software flow control, the following error is encountered:
>> qcom_geni_serial 1a80000.serial: Couldn't find suitable
>> clock rate for 56000000, 3500000, 2500000, 1152000, 921600, 19200
>>
>> During hardware flow control testing, a “Retry 0: Got ZCAN error” is
>> observed.
>>
>> To address these issues, update the UART frequency table to include all
>> supported frequencies according to the frequency plan.
> 
> Would this need fixes tag?
> 

Yes, it needs fixes tag. I will add it in the next version.
Thank you for pointing this.

Thanks & Regards,
Manikanta.

>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>>  drivers/clk/qcom/gcc-ipq5424.c | 16 +++++++++++-----
>>  1 file changed, 11 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/gcc-ipq5424.c b/drivers/clk/qcom/gcc-ipq5424.c
>> index d5b218b76e29..37b1a3ff8f4e 100644
>> --- a/drivers/clk/qcom/gcc-ipq5424.c
>> +++ b/drivers/clk/qcom/gcc-ipq5424.c
>> @@ -592,13 +592,19 @@ static struct clk_rcg2 gcc_qupv3_spi1_clk_src = {
>>  };
>>
>>  static const struct freq_tbl ftbl_gcc_qupv3_uart0_clk_src[] = {
>> -	F(960000, P_XO, 10, 2, 5),
>> -	F(4800000, P_XO, 5, 0, 0),
>> -	F(9600000, P_XO, 2, 4, 5),
>> -	F(16000000, P_GPLL0_OUT_MAIN, 10, 1, 5),
>> +	F(3686400,  P_GCC_GPLL0_OUT_MAIN_DIV_CLK_SRC, 1, 144, 15625),
>> +	F(7372800,  P_GCC_GPLL0_OUT_MAIN_DIV_CLK_SRC, 1, 288, 15625),
>> +	F(14745600, P_GCC_GPLL0_OUT_MAIN_DIV_CLK_SRC, 1, 576, 15625),
>>  	F(24000000, P_XO, 1, 0, 0),
>>  	F(25000000, P_GPLL0_OUT_MAIN, 16, 1, 2),
>> -	F(50000000, P_GPLL0_OUT_MAIN, 16, 0, 0),
>> +	F(32000000, P_GPLL0_OUT_MAIN, 1, 1, 25),
>> +	F(40000000, P_GPLL0_OUT_MAIN, 1, 1, 20),
>> +	F(46400000, P_GPLL0_OUT_MAIN, 1, 29, 500),
>> +	F(48000000, P_GPLL0_OUT_MAIN, 1, 3, 50),
>> +	F(51200000, P_GPLL0_OUT_MAIN, 1, 8, 125),
>> +	F(56000000, P_GPLL0_OUT_MAIN, 1, 7, 100),
>> +	F(58982400, P_GPLL0_OUT_MAIN, 1, 1152, 15625),
>> +	F(60000000, P_GPLL0_OUT_MAIN, 1, 3, 40),
>>  	F(64000000, P_GPLL0_OUT_MAIN, 12.5, 0, 0),
>>  	{ }
>>  };
>>
>> --
>> 2.34.1
>>