linux-kernel - Re: [PATCH v2 1/2] drm/omap/dss: Use of_property_present() to test existence of DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d53265c-0d95-4264-a661-9f4e076f4e8d@ideasonboard.com>
Date: Fri, 24 Jan 2025 09:22:44 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] drm/omap/dss: Use of_property_present() to test
 existence of DT property

Hi,

On 14/01/2025 16:58, Krzysztof Kozlowski wrote:
> of_property_read_bool() should be used only on boolean properties.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Changes in v2:
> 1. New patch - split from the next one.
> ---
>   drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index 7b2df3185de4..319f0a1d23a7 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -1236,7 +1236,7 @@ static int dss_video_pll_probe(struct dss_device *dss)
>   	if (!np)
>   		return 0;
>   
> -	if (of_property_read_bool(np, "syscon-pll-ctrl")) {
> +	if (of_property_present(np, "syscon-pll-ctrl")) {
>   		dss->syscon_pll_ctrl = syscon_regmap_lookup_by_phandle(np,
>   			"syscon-pll-ctrl");
>   		if (IS_ERR(dss->syscon_pll_ctrl)) {

Thanks, applying these to drm-misc-next.

  Tomi