linux-kernel - Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <976580f4-2e2c-4269-b5a6-2f9431cecaf8@ideasonboard.com>
Date: Fri, 24 Jan 2025 09:28:34 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Sean Anderson <sean.anderson@...ux.dev>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Michal Simek <michal.simek@....com>, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm: zynqmp_dp: Unlock on error in
 zynqmp_dp_bridge_atomic_enable()

Hi,

On 24/01/2025 01:56, Sean Anderson wrote:
> On 11/12/24 12:22, Sean Anderson wrote:
>> On 11/12/24 11:43, Laurent Pinchart wrote:
>>> On Tue, Nov 12, 2024 at 09:41:58AM -0500, Sean Anderson wrote:
>>>> On 11/12/24 00:27, Laurent Pinchart wrote:
>>>>> Hi Dan,
>>>>>
>>>>> Thank you for the patch.
>>>>>
>>>>> On Mon, Nov 11, 2024 at 12:06:10PM +0300, Dan Carpenter wrote:
>>>>>> We added some locking to this function, but accidentally forgot to unlock
>>>>>> if zynqmp_dp_mode_configure() failed.  Use a guard lock to fix it.
>>>>>>
>>>>>> Fixes: a7d5eeaa57d7 ("drm: zynqmp_dp: Add locking")
>>>>>> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
>>>>>
>>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>>>>>
>>>>> Sean, how about replacing all the mutex_lock()/mutex_unlock() calls
>>>>> you've added in a7d5eeaa57d7 with guards ?
>>>>
>>>> I have no objection to that.
>>>
>>> Would you send a patch ? Otherwise I can do it.
>>>
>>
>> I can send a patch, but it will not be for a week or two.
>>
>> --Sean
> 
> Just following up on this; will the above patched be merged? I would
> prefer to keep the bugfix and the conversion separate.

I'll push to drm-misc-fixes.

  Tomi