linux-kernel - Re: [PATCH] drm/omap: Remove hdmi5_core_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe43a7a8-a202-4dc4-aded-f68d52d65928@ideasonboard.com>
Date: Fri, 24 Jan 2025 09:33:45 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: linux@...blig.org
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 simona@...ll.ch, airlied@...il.com
Subject: Re: [PATCH] drm/omap: Remove hdmi5_core_handle_irqs()

Hi,

On 18/12/2024 04:01, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> hdmi5_core_handle_irqs() is a function that was copied from omapdss by
> commit f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> 
> but it wasn't used in the original anyway.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>   drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 17 -----------------
>   drivers/gpu/drm/omapdrm/dss/hdmi5_core.h |  1 -
>   2 files changed, 18 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
> index 21564c38234f..12ef47cd232b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
> @@ -545,23 +545,6 @@ static void hdmi_core_enable_interrupts(struct hdmi_core_data *core)
>   	REG_FLD_MOD(core->base, HDMI_CORE_IH_MUTE, 0x0, 1, 0);
>   }
>   
> -int hdmi5_core_handle_irqs(struct hdmi_core_data *core)
> -{
> -	void __iomem *base = core->base;
> -
> -	REG_FLD_MOD(base, HDMI_CORE_IH_FC_STAT0, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_FC_STAT1, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_FC_STAT2, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_AS_STAT0, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_PHY_STAT0, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_I2CM_STAT0, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_CEC_STAT0, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_VP_STAT0, 0xff, 7, 0);
> -	REG_FLD_MOD(base, HDMI_CORE_IH_I2CMPHY_STAT0, 0xff, 7, 0);
> -
> -	return 0;
> -}
> -
>   void hdmi5_configure(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
>   		struct hdmi_config *cfg)
>   {
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
> index 070cbf5fb57d..b8ed21156e8c 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
> @@ -286,7 +286,6 @@ int hdmi5_core_ddc_read(void *data, u8 *buf, unsigned int block, size_t len);
>   void hdmi5_core_ddc_uninit(struct hdmi_core_data *core);
>   
>   void hdmi5_core_dump(struct hdmi_core_data *core, struct seq_file *s);
> -int hdmi5_core_handle_irqs(struct hdmi_core_data *core);
>   void hdmi5_configure(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
>   			struct hdmi_config *cfg);
>   int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core);

Thanks, applying to drm-misc-next.

  Tomi