linux-kernel - Re: [PATCH v3 4/4] media: ox05b1s: Add support for Omnivision OS08A20 raw sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250124-bizarre-cherry-mayfly-9f2bce@krzk-bin>
Date: Fri, 24 Jan 2025 09:09:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mirela Rabulea <mirela.rabulea@....com>
Cc: mchehab@...nel.org, sakari.ailus@...ux.intel.com, 
	hverkuil-cisco@...all.nl, laurent.pinchart+renesas@...asonboard.com, robh@...nel.org, 
	krzk+dt@...nel.org, bryan.odonoghue@...aro.org, laurentiu.palcu@....com, 
	robert.chiras@....com, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	LnxRevLi@....com, kieran.bingham@...asonboard.com, hdegoede@...hat.com, 
	dave.stevenson@...pberrypi.com, mike.rudenko@...il.com, alain.volmat@...s.st.com, 
	devicetree@...r.kernel.org, conor+dt@...nel.org, alexander.stein@...tq-group.com, 
	umang.jain@...asonboard.com, zhi.mao@...iatek.com, festevam@...x.de, 
	julien.vuillaumier@....com, alice.yuan@....com
Subject: Re: [PATCH v3 4/4] media: ox05b1s: Add support for Omnivision
 OS08A20 raw sensor

On Fri, Jan 24, 2025 at 02:12:43AM +0200, Mirela Rabulea wrote:
> @@ -758,6 +914,9 @@ static int ox05b1s_read_chip_id(struct ox05b1s *sensor)
>  	}
>  
>  	switch (chip_id) {
> +	case 0x530841:
> +		camera_name = "os08a20";
> +		break;

Ah, so here I see missing second device support.

It is still confusing to see that you use here some sort of
autodetection, but in the same time not.


>  	case 0x580542:
>  		camera_name = "ox05b1s";
>  		break;
> @@ -900,6 +1059,24 @@ static void ox05b1s_remove(struct i2c_client *client)
>  static DEFINE_RUNTIME_DEV_PM_OPS(ox05b1s_pm_ops, ox05b1s_runtime_suspend,
>  				 ox05b1s_runtime_resume, NULL);
>  
> +static const struct ox05b1s_plat_data os08a20_data = {
> +	.name			= "os08a20",
> +	.chip_id		= 0x530841,
> +	.native_width		= 3872, /* 16 dummy + 3840 active pixels + 16 dummy */
> +	.native_height		= 2192, /* 16 dummy + 2160 active lines + 16 dummy */
> +	.active_top		= 16,
> +	.active_left		= 16,
> +	.active_width		= 3840,
> +	.active_height		= 2160,
> +	.supported_modes	= os08a20_supported_modes,
> +	.default_mode_index	= 0,
> +	.supported_codes	= os08a20_supported_codes,
> +	.hdr_modes		= os08a20_hdr_modes,
> +	.hdr_modes_count	= ARRAY_SIZE(os08a20_hdr_modes),
> +	.set_hdr_mode		= os08a20_set_hdr_mode,
> +
> +};
> +
>  static const struct ox05b1s_plat_data ox05b1s_data = {
>  	.name			= "ox05b1s",
>  	.chip_id		= 0x580542,
> @@ -912,9 +1089,16 @@ static const struct ox05b1s_plat_data ox05b1s_data = {
>  	.supported_modes	= ox05b1s_supported_modes,
>  	.default_mode_index	= 0,
>  	.supported_codes	= ox05b1s_supported_codes,
> +	.hdr_modes		= NULL,
> +	.hdr_modes_count	= 0,
> +	.set_hdr_mode		= NULL,
>  };
>  
>  static const struct of_device_id ox05b1s_of_match[] = {
> +	{
> +		.compatible = "ovti,os08a20",
> +		.data = &os08a20_data,

And here static configuration of model, not autodetection.


Best regards,
Krzysztof