linux-kernel - Re: [PATCH 1/3] cgroup/rstat: Fix forceidle time in cpu.stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf5k7vmtqa2a5e6haxghvsolnydaczrz5n3bkluttmula5s35y@z35txmj4bxsb>
Date: Fri, 24 Jan 2025 10:22:42 +0100
From: Michal Koutný <mkoutny@...e.com>
To: Abel Wu <wuyun.abel@...edance.com>
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>, 
	Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...hat.com>, 
	Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, 
	Vincent Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, 
	Valentin Schneider <vschneid@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Yury Norov <yury.norov@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Bitao Hu <yaoma@...ux.alibaba.com>, Chen Ridong <chenridong@...wei.com>, 
	"open list:CONTROL GROUP (CGROUP)" <cgroups@...r.kernel.org>, "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] cgroup/rstat: Fix forceidle time in cpu.stat

Hello.

On Fri, Jan 24, 2025 at 01:47:01AM +0800, Abel Wu <wuyun.abel@...edance.com> wrote:
> The commit b824766504e4 ("cgroup/rstat: add force idle show helper")
> retrieves forceidle_time outside cgroup_rstat_lock for non-root cgroups
> which can be potentially inconsistent with other stats.
> 
> Rather than reverting that commit, fix it in a way that retains the
> effort of cleaning up the ifdef-messes.

Sorry, I'm blind, where's the change moving wrt cgroup_rstat_lock?
(I only see unuse of root cgroup's bstat and a few renames).

Thanks,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)