linux-kernel - Re: [PATCH 2/3] cgroup/rstat: Cleanup cpu.stat once for all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <764096dd-4d2c-4934-9c07-500a476bb140@bytedance.com>
Date: Fri, 24 Jan 2025 18:00:34 +0800
From: Abel Wu <wuyun.abel@...edance.com>
To: Michal Koutný <mkoutny@...e.com>
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>,
 Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Bitao Hu
 <yaoma@...ux.alibaba.com>, Thomas Gleixner <tglx@...utronix.de>,
 Yury Norov <yury.norov@...il.com>, Chen Ridong <chenridong@...wei.com>,
 "open list:CONTROL GROUP (CGROUP)" <cgroups@...r.kernel.org>,
 "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] cgroup/rstat: Cleanup cpu.stat once for all



On 1/24/25 5:22 PM, Michal Koutný Wrote:
> On Fri, Jan 24, 2025 at 01:47:02AM +0800, Abel Wu <wuyun.abel@...edance.com> wrote:
>> -static void cgroup_force_idle_show(struct seq_file *seq, struct cgroup_base_stat *bstat)
>> +static void __append_bstat(struct seq_file *seq, struct cgroup_base_stat *bstat,
>> +			   struct bstat_entry *entry)
> 
> Not sure if starting with double underscore is needed when the helper is
> `static`. Also something like s/append/show/ -> cgroup_bstat_entry_show.

Yeah, "cgroup_bstat_entry_show" looks better! Will fix.

Thanks,
	Abel