linux-kernel - Re: [PATCH bpf-next v2 00/10] selftests/bpf: Migrate test_xdp_redirect_multi.sh to test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b00deb3a-175a-4d04-9fc0-d71d317ad86e@bootlin.com>
Date: Fri, 24 Jan 2025 11:25:44 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
 Alexis Lothore <alexis.lothore@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 00/10] selftests/bpf: Migrate
 test_xdp_redirect_multi.sh to test_progs

Hi Stanislav

On 1/23/25 8:45 PM, Stanislav Fomichev wrote:
> On 01/21, Bastien Curutchet (eBPF Foundation) wrote:
>> Hi all,
>>
>> This patch series continues the work to migrate the *.sh tests into
>> prog_tests framework.
>>
>> test_xdp_redirect_multi.sh tests the XDP redirections done through
>> bpf_redirect_map().
>>
>> This is already partly covered by test_xdp_veth.c that already tests
>> map redirections at XDP level. What isn't covered yet by test_xdp_veth is
>> the use of the broadcast flags (BPF_F_BROADCAST or BPF_F_EXCLUDE_INGRESS)
>> and XDP egress programs.
>>
>> Hence, this patch series add test cases to test_xdp_veth.c to get rid of
>> the test_xdp_redirect_multi.sh:
>>   - PATCH 1 to 5 rework test_xdp_veth to make it more generic and allow to
>>     configure different test cases
>>   - PATCH 6 adds test cases for 'classic' bpf_redirect_map()
>>   - PATCH 7 & 8 covers the broadcast flags
>>   - PATCH 9 covers the XDP egress programs
>>   - PATCH 10 removes test_xdp_redirect_multi.sh
>>
>> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@...tlin.com>
>> ---
>> Changes in v2:
>> - Use serial_test_* to avoid conflict between tests
> 
> Do I understand correctly that we want them serial mostly because of the
> hard-coded namespace names? If yes, might be a good idea to follow up
> (separately) with a way to generate unique name for each subtest and
> unserialize them.
> 

Yes, that's it. Ok, I'll send a V3 with random namespace names.

> (If you have time/desire, I think there is a bunch of similar cases
> where we have to serialize tests, might as well undo that).
> 

I'll try to look at it.

> I looked briefly through the series, looks good:
> 
> Acked-by: Stanislav Fomichev <sdf@...ichev.me>

Best regards,
Bastien