linux-kernel - Re: [PATCH v2 1/5] dt-bindings: clock: qcom: Add compatible for QCM6490 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <449b7943-4161-4e78-a591-f01345b4f207@quicinc.com>
Date: Fri, 24 Jan 2025 16:02:41 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, <quic_imrashai@...cinc.com>,
        <quic_jkona@...cinc.com>
CC: <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: clock: qcom: Add compatible for
 QCM6490 boards



On 9/16/2024 2:10 PM, Krzysztof Kozlowski wrote:
> On 13/09/2024 07:18, Taniya Das wrote:
>>
>>
>> On 8/17/2024 2:51 PM, Krzysztof Kozlowski wrote:
>>> On 16/08/2024 10:32, Taniya Das wrote:
>>>> Add the new QCM6490 compatible to support the reset functionality for
>>>> Low Power Audio subsystem.
>>>>
>>>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>>>
>>> Subject is odd - I do not see here anything related to boards.
>>>
>>> Anyway, this is incomplete. Look at the rest of the binding - you did
>>> not update any part related to proper clock constraints.
>>>
>>
>> Not sure if I understand the concern, but I was of the opinion that I
>> have added a new compatible for QCM6490 board , but no new clock
>> constraint added.
>>
>>
>> I see a patch from you
>> https://lore.kernel.org/all/20240817094605.27185-1-krzysztof.kozlowski@linaro.org/
>> and I guess it fixes the constraints.
>>
> 
> Look at entire file. This is incomplete.
> 

Please accept apologies for taking longer than expected to respond on 
this thread.

Yes I think you meant something as below to be taken care as 
constraints, which I have overlooked in my earlier patch.


@@ -26,6 +26,7 @@ properties:

    compatible:
      enum:
+      - qcom,qcm6490-lpassaudiocc
        - qcom,sc7280-lpassaoncc
        - qcom,sc7280-lpassaudiocc
        - qcom,sc7280-lpasscorecc
@@ -125,6 +126,18 @@ allOf:

          reg:
            maxItems: 1
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: qcom,qcm6490-lpassaudiocc
+
+    then:
+      properties:
+        reg:
+          items:
+            - description: lpass core cc register
+            - description: lpass audio csr register

> Best regards,
> Krzysztof

-- 
Thanks & Regards,
Taniya Das.