linux-kernel - Re: [PATCH 1/7] zram: switch to non-atomic entry locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <u7wjtvnxxukalqxm4xsw7e2trbnwumev4qsslvowrqrwebnucw@bthhaq4p7635>
Date: Fri, 24 Jan 2025 20:09:55 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Hillf Danton <hdanton@...a.com>
Cc: Minchan Kim <minchan@...nel.org>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, 
	Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH 1/7] zram: switch to non-atomic entry locking

On (25/01/24 20:03), Sergey Senozhatsky wrote:
> On (25/01/24 18:30), Hillf Danton wrote:
> > On (25/01/22 14:57), Sergey Senozhatsky wrote:
> > > 
> > > -	for (index = 0; index < num_pages; index++)
> > > -		spin_lock_init(&zram->table[index].lock);
> > > +	for (index = 0; index < num_ents; index++)
> > > +		init_rwsem(&zram->locks[index].lock);
> > 
> > Curious if lockdep trick [1] is needed here.
> 
> These bucket locks are not part of the v2 which I'm currnetly
> working on.

v2 will also come with a draft version of new zsmalloc API that does
not impose atomicity restrictions in zs_map_object() (no local CPU
lock and no migration rwlock involved.)