linux-kernel - Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512914f2-1df7-4c24-ab4b-6a246060d537@arm.com>
Date: Fri, 24 Jan 2025 13:30:27 +0100
From: Kevin Brodsky <kevin.brodsky@....com>
To: Alexander Gordeev <agordeev@...ux.ibm.com>
Cc: Qi Zheng <zhengqi.arch@...edance.com>,
 Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>, linux-mm@...ck.org,
 linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade

On 24/01/2025 09:24, Alexander Gordeev wrote:
>>>  	}
>>>  	if (end > _REGION1_SIZE) {
>>>  		pgd = crst_table_alloc(mm);
>>>  		if (unlikely(!pgd))
>>>  			goto err_pgd;
>>>  		crst_table_init(pgd, _REGION1_ENTRY_EMPTY);
>>> +		pagetable_pgd_ctor(virt_to_ptdesc(pgd));
>> I was hoping this might be equivalent to pgd_alloc() but it does not
>> include a call to crst_table_init(). Since adding it would be apparently
>> undesirable (having read the other thread), it seems reasonable to add
>> the explicit constructor call.
> We were thinking about a follow-up cleanup that addresses it all, but this
> patch is a targeted fix to catch up your and Qi Zheng series in the still
> open merge window.

Sure that's fair, this patch does fix the issue and the cleanup can wait
until the next cycle.

Reviewed-by: Kevin Brodsky <kevin.brodsky@....com>

- Kevin