lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b0fc02f1f3a6221e12e465207aa606bf15a49ade.camel@gmail.com>
Date: Fri, 24 Jan 2025 12:32:45 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: Markus Burri <markus.burri@...com>, linux-kernel@...r.kernel.org
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich	
 <Michael.Hennerich@...log.com>, Alisa-Dariana Roman
 <alisa.roman@...log.com>,  Jonathan Cameron	 <jic23@...nel.org>,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7192: fix channel select

On Fri, 2025-01-24 at 12:37 +0100, Markus Burri wrote:
> Channel configuration doesn't work as expected.
> For FIELD_PREP the bit mask is needed and not the bit number.
> 
> Signed-off-by: Markus Burri <markus.burri@...com>
> ---

LGTM. Just missing a fixes tag. With that:

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

>  drivers/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index 1c87db0e0460..c4effe8429c8 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -1082,7 +1082,7 @@ static int ad7192_update_scan_mode(struct iio_dev
> *indio_dev, const unsigned lon
>  
>  	conf &= ~AD7192_CONF_CHAN_MASK;
>  	for_each_set_bit(i, scan_mask, 8)
> -		conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i);
> +		conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i));
>  
>  	ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf);
>  	if (ret < 0)
> 
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ