linux-kernel - Re: [PATCH] iio: dac: ad5791: fix storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7aa9c53958c1e685bff9f863890bd2f0f29cad5.camel@gmail.com>
Date: Fri, 24 Jan 2025 12:48:21 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Michael Hennerich
	 <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: ad5791: fix storage

On Wed, 2025-01-22 at 17:16 -0600, David Lechner wrote:
> IIO uses "natural" alignment so storagebits should always be a power of
> 2. Change storagebits to 32 since that is the natural size to store 24
> bits of data.
> 
> The ad5791 driver currently doesn't use this field anywhere and doesn't
> support buffered writes, so this does not change anything. We just don't
> want anyone to think that it is OK to have storagebits = 24 in other
> drivers.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

> Since this is purely cosmetic, I didn't bother with a fixes flag.
> ---
>  drivers/iio/dac/ad5791.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c
> index
> 57374f78f6b885e1d4f2fb452ac0563b85fc222e..034228a7c059f136cdecfb4683228d0be4c3
> 7477 100644
> --- a/drivers/iio/dac/ad5791.c
> +++ b/drivers/iio/dac/ad5791.c
> @@ -294,7 +294,7 @@ static const struct ad5791_chip_info _name##_chip_info =
> {		\
>  			.scan_type = {					\
>  				.sign = 'u',				\
>  				.realbits = (bits),			\
> -				.storagebits = 24,			\
> +				.storagebits = 32,			\
>  				.shift = (_shift),			\
>  			},						\
>  			.ext_info = ad5791_ext_info,			\
> 
> ---
> base-commit: 012b8276f08a67b9f2e2fd0f35363ae4a75e5267
> change-id: 20250122-iio-dac-ad5791-fix-storagebits-9f86efa07abb
> 
> Best regards,