linux-kernel - Re: [PATCH 3/7] rtc: pm8xxx: add support for uefi offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5OeoMUAVmhxElwA@hovoldconsulting.com>
Date: Fri, 24 Jan 2025 15:07:28 +0100
From: Johan Hovold <johan@...nel.org>
To: Tobias Heider <tobias.heider@...onical.com>
Cc: Johan Hovold <johan+linaro@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Jonathan Marek <jonathan@...ek.ca>, linux-arm-msm@...r.kernel.org,
	linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] rtc: pm8xxx: add support for uefi offset

On Fri, Jan 24, 2025 at 01:56:56PM +0100, Tobias Heider wrote:
> On Mon, Jan 20, 2025 at 03:41:48PM GMT, Johan Hovold wrote:
> > On many Qualcomm platforms the PMIC RTC control and time registers are
> > read-only so that the RTC time can not be updated. Instead an offset
> > needs be stored in some machine-specific non-volatile memory, which the
> > driver can take into account.
> > 
> > Add support for storing a 32-bit offset from the GPS time epoch in a
> > UEFI variable so that the RTC time can be set on such platforms.

> Thanks for the great work Johan, seems to work nicely here!

Thanks for testing.

> I think you might need to add MODULE_IMPORT_NS(EFIVAR) for the efivar_*
> API calls you added.

It's already there (inside the ifdef):

> > +#ifdef CONFIG_EFI
> > +
> > +MODULE_IMPORT_NS("EFIVAR");

Johan