linux-kernel - RE: [PATCH v4 3/9] soc: renesas: rz-sysc: Move RZ/G3S SoC detection to the SYSC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSBPR01MB2775EBD7E2A074F8F2CDE8BBFFE32@OSBPR01MB2775.jpnprd01.prod.outlook.com>
Date: Fri, 24 Jan 2025 16:07:04 +0000
From: John Madieu <john.madieu.xa@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, Biju Das <biju.das.jz@...renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "john.madieu@...il.com"
	<john.madieu@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "magnus.damm@...il.com"
	<magnus.damm@...il.com>
Subject: RE: [PATCH v4 3/9] soc: renesas: rz-sysc: Move RZ/G3S SoC detection
 to the SYSC driver



> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Friday, January 24, 2025 3:18 PM
> Subject: Re: [PATCH v4 3/9] soc: renesas: rz-sysc: Move RZ/G3S SoC
> detection to the SYSC driver
> 
> Hi John,
> 

Hi Geert,

Thanks for your review.

> On Thu, Jan 23, 2025 at 6:05 PM John Madieu
> <john.madieu.xa@...renesas.com> wrote:
> > From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> >
> > Now that we have SoC detection in the RZ SYSC driver, move the RZ/G3S
> > SoC detection to it. The SYSC provides SoC ID in its own registers.
> >
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> > Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>
> 
> Thanks for your patch!
> 
> > +#define SYS_LSI_DEVID_SPECIFIC GENMASK(27, 0)
> > +#define SYS_MAX_REG            0xe20
> 
> Unused.

Will be removed in v5.

> 
> > +
> 
> The rest LGTM, so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
Regards,
John